swiftlang/swift

[SR-11795] Replace OSX with macOS pretty much everywhere

Open

#54,205 opened on Nov 17, 2019

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
bugcompilergood first issue

Description
Previous ID SR-11795
Radar rdar://35127522
Original Reporter @CodaFi
Type Bug
Status In Progress
Resolution
Votes 1
Component/s Compiler
Labels Bug, StarterBug
Assignee Tudes100 (JIRA)
Priority Medium

md5: 01b356d7a526d3a65852312ab839b033

Issue Description:

The codebase still has quite a few places where we use the spelling OSX instead of macOS, especially in API availability stuff. While not all usages of OS X are incorrect - in particular, it is not correct to simply find-and-replace all the usages of "OS X" and "OSX" with "macOS", it's still probably a good idea to scrub the codebase of the non-essential ones. Graydon has already done most of the heavy lifting, so the end result is just responding to the feedback on https://github.com/apple/swift/pull/12674, rebasing it, and running the tests to verify the changes.

Contributor guide

Tech stack
None
Domain
backenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift language knowledgeGit rebasingRunning compiler tests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review PR #12674 (https://github.com/apple/swift/pull/12674) which contains initial work by Graydon to replace 'OSX' with 'macOS'. Address any feedback comments on that PR, rebase it onto the current master branch, and run the compiler test suite to verify no regressions. Also check for any remaining occurrences of 'OSX' in API availability and other code that should be updated.