swiftlang/swift

[SR-8252] Consolidate and Fix -debug-crash-* Flags

Open

#50,784 opened on Jul 13, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
compilergood first issueimprovement

Description
Previous ID SR-8252
Radar None
Original Reporter @CodaFi
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: 85fb82c2ea0303f5308473609b79bde5

Issue Description:

Currently, Swift has -debug-crash-immediately and -debug-crash-after-parse and -debug-assert-after-parse. The problem is twofold:

1) -debug-assert-after-parse understands the old hat meaning of "-parse" which used to mean "parse and type check". Now that the compiler understands these are distinct actions, this flag is misnamed.

2) The more useful distinction is crashing immediately versus crashing after a particular phase.

We should generalize -debug-assert and -debug-crash to mean "assert after the current frontend action finishes" or "crash after the current frontend action finishes" respectively. -debug-crash-immediately should still be retained because there needs to be a way to crash argument parsing.

Contributor guide

Tech stack
swift
Domain
developer experiencecli
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swiftcompiler frontend actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the current implementation of debug crash * flags in the Swift compiler source (likely in include/swift/Option/Options.td or lib/Frontend/). Look at how debug assert after parse and similar flags are handled. Review the discussion in comments for prior attempts or suggestions. Plan to rename debug assert after parse to debug assert after typecheck or similar, and consolidate into debug crash and debug assert flags. Ensure debug crash immediately remains unchanged.