swiftlang/swift

[SR-6736] Enforce 16-bit limit for # of function parameters, # of tuple type element

Open

#49,285 opened on Jan 11, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcompilergood first issue

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-6736
Radar None
Original Reporter @DougGregor
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ea27fac0ee252473c9618a9257498092

Issue Description:

Swift's ABI uses 16 bits to store the number of parameter types in a function type and the number of element types in a tuple type. We should enforce these limits in the parser, so they don't slip through and become crashes at later phases.

Contributor guide

Research direction
Inspect the parser code for function type and tuple type parsing. Add a check to enforce the 16 bit limit on the number of parameters and tuple elements, emitting a diagnostic if exceeded.
Tech stack
swift
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75