swiftlang/swift

[SR-6264] Unify duplicated code in GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally()

Open

#48,814 opened on Nov 1, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
IRGencompilergood first issueimprovement

Description
Previous ID SR-6264
Radar None
Original Reporter @gparker42
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, IRGen, StarterBug
Assignee None
Priority Medium

md5: 7fe2948a0ff34a9d22f375125e2fe476

Issue Description:

Functions GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally() have duplicated code that checks whether a declaration may be externally used based on its access level. This duplication should be fixed.

Possible solution: add a function to class ValueDecl to do the work, and call it from both places.

Contributor guide

Tech stack
swift
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftCompiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the two functions GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally() in the Swift compiler source code. They are likely in files related to IRGen and SILOptimizer. Identify the duplicated logic and create a new method in the ValueDecl class that encapsulates the access level check. Then replace the duplicate code in both functions with calls to this new method. Ensure tests still pass.