swiftlang/swift

[SR-5362] StdlibUnittest allows redeclaration of the same-named test; ignores all but last

Open

#47,936 opened on Jul 3, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
buggood first issuestandard library

Description
Previous ID SR-5362
Radar rdar://problem/33107335
Original Reporter @dabrahams
Type Bug
Status In Progress
Resolution
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: fc8e733c68f3cbbcf633f37b9a56c975

Issue Description:

For example, these two tests have the same name. The first one wouldn't pass, but it never gets run because of the second one.

This affects the reliability and maintainability of our testing. Someone needs to make StdlibUnittest cause a hard error in these cases, identify all the duplicated tests, strip out the bogus ones, and rename any others.

Note: the particular bogus tests referenced here will probably be gone from master by the time this bug is addressed. The links point to an older version of the file.

Contributor guide

Tech stack
swift
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Swift knowledgefamiliarity with StdlibUnittestability to search for duplicate test names
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the current state of duplicate test names in the Swift test suite. The issue references two tests in StringViews.swift (old commit), so start by searching the current validation test/stdlib/StringViews.swift for similarly named tests. Additionally, grep the entire test directory for duplicate test function names registered via StdlibUnittest. Look at the StdlibUnittest source code (likely in swift/stdlib/private/StdlibUnittest) to understand how tests are registered and where to add a hard error for duplicate names. Identify all duplicates, remove bogus ones, and rename any that need renaming. Consider checking comments on the issue for any recent activity or guidance.