swiftlang/swift

[SR-4824] Add tests to check Collection constraints are being enforced

Open

#47,401 opened on May 7, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
buggood first issuestandard library

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-4824
Radar rdar://problem/32134714
Original Reporter @airspeedswift
Type Bug
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee djwbrown (JIRA)
Priority Medium

md5: 6b6aabc9be01be2d9974ed98c3c057f8

Issue Description:

https://github.com/apple/swift/pull/9379 removed tests confirming collection's associated types conformed to appropriate protocols e.g. MutableCollection.SubSequence: MutableCollection. Now the compiler is enforcing these, so they were just generating warnings.

They should be replaced by tests checking the compiler is enforcing these rules (by trying to create invalid collections and checking the error messages).

Contributor guide

Research direction
Write tests that intentionally create invalid collections to verify the compiler enforces Collection constraints, and check for appropriate error messages.
Tech stack
swift
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70