swiftlang/swift

[SR-4595] Tests generate lots of warnings

Open

#47,172 opened on Apr 14, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
buggood first issue

Description
Previous ID SR-4595
Radar None
Original Reporter @dabrahams
Type Bug
Votes 0
Component/s Project Infrastructure
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 3bb31b4381d569556f0d983141a18d9c

Issue Description:

Because tests pass even when they produce warnings, most people don't see this, but when a test fails, it really matters that the important information is not buried under a bunch of irrelevancies. We need both:

  1. To clean up all the existing warnings in tests (obviously, other than those that are part of what we're testing for, and while keeping the tests running)

  2. To put a system in place that will cause us to keep the tests clean of warnings.

Contributor guide

Tech stack
swift
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
SwiftSwift testing infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The issue requests cleaning up all existing warnings in test files and implementing a system to prevent future warnings. Investigate the current test suite in the swift repository, focusing on files like 'swift/test/' and related build scripts. Look for any existing CI configuration or testing guidelines. Consider starting with a small subset of warnings, such as deprecation warnings, and propose a plan for systematic cleanup.