swiftlang/swift

[SR-2961] utils/run-test should accept the same "optimization mode" flags build-script does

Open

#45,551 opened on Oct 15, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
contributor experiencegood first issuerun-testutils

Description
Previous ID SR-2961
Radar None
Original Reporter Beingessner (JIRA User)
Type Task
Votes 0
Component/s
Labels Task, StarterBug
Assignee None
Priority Medium

md5: 8f750d918784d982d243854e145f4366

Issue Description:

Currently run-test requires you to pass the build-directory for the compiler/stdlib to use for the tests, but this is tedious and requires the user to actually know what the name of the target they're building was.

A more ergonomic workflow would be to allow the same flags that build-script accepts to be passed to run-test, and have it derive the compiler from that. I'm not sure what the complete set of flags relevant flags is, but -d, -r, and -R are probably the most important. More complex scenarios can always fall-back to the current workflow.

Contributor guide

Tech stack
swiftshell
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of Swift build systemshell scriptingfamiliarity with build script flags
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the current run test script (likely in utils/) to understand how it accepts build directories. Examine the build script flags d, r, R to determine their meaning and how they map to build configurations. Propose modifications to run test to parse these flags and derive the appropriate build directory, and ensure tests for the new functionality are added.