swiftlang/swift

[SR-1717] Force -module-name "main" for %target-run-simple-swift

Open

#44,326 opened on Jun 9, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
buggood first issue

Description
Previous ID SR-1717
Radar None
Original Reporter @harlanhaskins
Type Bug
Votes 0
Component/s
Labels Bug, StarterBug, Test
Assignee None
Priority Medium

md5: 88bb4e4d7a2dac50fea1f7404c34a64a

Issue Description:

When running tests in the interpreter, there are lots of tests that fail because they're implicitly relying on the module name being the binary name.

For example, in Optionals.swift, line 379, we expect an optional to print as "Optional(Optional.TestNoString)", but it comes in as "Optional(main.TestNoString)" because the module is set to main in the interpreter.

The module should just always be main when running tests.

Contributor guide

Tech stack
swift
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Swift compiler basicsFamiliarity with test runner scripts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the test runner tool %target run simple swift in the Swift repository. Locate where the module name is set for test execution, likely in a script or CMake configuration. Modify it to always pass module name main when running tests. Verify that the failing tests then produce expected output.