swiftlang/swift

[SR-1554] //*/ does not close multi-line comment

Open

#44,163 opened on May 18, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
bugcompilergood first issueparser

Description
Previous ID SR-1554
Radar rdar://problem/26327545
Original Reporter @jckarter
Type Bug
Votes 0
Component/s Compiler
Labels Bug, Parser, StarterBug
Assignee None
Priority Medium

md5: 2416cb9a05334e4c8d080874b91f289e

Issue Description:

//*/ should close a /* comment, but does not:

/*
//*/
print("wat")

Contributor guide

Tech stack
swift
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Swift lexer
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the lexer's handling of block comments. The issue occurs because the lexer likely doesn't treat '//*/' as a valid closing sequence. Locate the comment parsing logic in the lexer source files (e.g., Lexer.cpp or similar) and understand how it detects the end of a block comment. The fix would involve adjusting the logic to recognize '//*/' as a closing delimiter when inside a /* comment.