swiftlang/swift

[SR-1554] //*/ does not close multi-line comment

Open

#44,163 opened on May 18, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcompilergood first issueparser

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-1554
Radar rdar://problem/26327545
Original Reporter @jckarter
Type Bug
Votes 0
Component/s Compiler
Labels Bug, Parser, StarterBug
Assignee None
Priority Medium

md5: 2416cb9a05334e4c8d080874b91f289e

Issue Description:

//*/ should close a /* comment, but does not:

/*
//*/
print("wat")

Contributor guide

Research direction
Look at the Swift compiler's lexer or parser code that handles multi line comments. Find where `/*` is opened and how `*/` is matched, and ensure that `//*/` is correctly recognized as closing the comment. The issue is that `//*/` should close a multi line comment but currently does not.
Tech stack
swift
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80