swiftlang/swift

[SR-1124] Drop FileCheck from test/1_stdlib, use StdlibUnittest instead

Open

#43,737 opened on Apr 1, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
good first issueimprovementstandard library

Description
Previous ID SR-1124
Radar None
Original Reporter @modocache
Type Improvement
Votes 0
Component/s Standard Library
Labels Improvement, StarterBug, Test
Assignee None
Priority Medium

md5: 5245d992633498d3acacd3655548dd7c

Issue Description:

Swift's test/1_stdlib directory is meant to include tests for the Swift stdlib. Most of these are written using the testing framework designed for this purpose, StdlibUnittest. However, some use an ad-hoc system of printing strings to stdout, then checking the output via FileCheck.

The following tests should be written using StdlibUnittest (and no longer reference FileCheck):

  1. test/1_stdlib/ArrayBridge.swift

  2. test/1_stdlib/BitwiseOperationsType.swift

  3. test/1_stdlib/BridgeNonVerbatim.swift

  4. test/1_stdlib/Bridgeable.swift

  5. test/1_stdlib/CGGeometry.swift

  6. test/1_stdlib/Collection.swift

  7. test/1_stdlib/CollectionOfOne.swift

  8. test/1_stdlib/Float.swift

  9. test/1_stdlib/FloatingPointIR.swift

  10. test/1_stdlib/HeapBuffer.swift

  11. test/1_stdlib/ImplicitlyUnwrappedOptional.swift

  12. test/1_stdlib/KVO.swift

  13. test/1_stdlib/LogicValue.swift

  14. test/1_stdlib/Map.swift

  15. test/1_stdlib/NSObject.swift

  16. test/1_stdlib/NSUndoManager.swift

  17. test/1_stdlib/NewArray.swift.gyb

  18. test/1_stdlib/NewString.swift

  19. test/1_stdlib/NewStringAppending.swift

  20. test/1_stdlib/Nil.swift

  21. test/1_stdlib/Reflection.swift

  22. test/1_stdlib/Reflection_jit.swift

  23. test/1_stdlib/Reflection_objc.swift

  24. test/1_stdlib/SegmentAlignment.c

  25. test/1_stdlib/SpriteKit.swift

  26. test/1_stdlib/StringReallocation.swift

  27. test/1_stdlib/TypeName.swift

  28. test/1_stdlib/UIKit.swift

  29. test/1_stdlib/UIViewControllerAdditions.swift

  30. test/1_stdlib/VarArgs.swift

  31. test/1_stdlib/Zip.swift

  32. test/1_stdlib/alloc_rounding.swift

  33. test/1_stdlib/integer_conversions.swift

  34. test/1_stdlib/sort_integers.swift

  35. test/1_stdlib/subString.swift

Contributor guide

Tech stack
swift
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SwiftStdlibUnittestFileCheck
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Review the list of 35 files in test/1 stdlib that use FileCheck for output verification. Learn the StdlibUnittest framework by examining existing tests that use it. Convert each file to use StdlibUnittest instead of printing strings and checking with FileCheck. Ensure the converted tests pass. Start with simpler files like test/1 stdlib/Nil.swift or test/1 stdlib/Map.swift.