swiftlang/swift

[SR-888] Sequence.minElement() and maxElement() should be protocol requirements (customization points)

Open

#43,500 opened on Mar 6, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
affects ABIgood first issuestandard libraryswift evolution proposal needed

Description
Previous ID SR-888
Radar rdar://problem/24999603
Original Reporter @gribozavr
Type Bug
Status In Progress
Resolution
Votes 0
Component/s Standard Library
Labels Bug, AffectsABI, StarterBug, StarterProposal, swift-evolution-proposal-needed
Assignee akhilmantha (JIRA)
Priority Medium

md5: 38f233c0b4c0d1508b74875d0c159d05

Issue Description:

Some collections naturally maintain sorted order and can implement `minElement()` and `maxElement()` in O(1). Thus, these algorithms should be protocol requirements to allow collection-specific customizations.

Note that `minElement()` and `maxElement()` that take predicates should continue to be pure extensions.

Contributor guide

Tech stack
swift
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift basicsProtocol oriented programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the current implementation of Sequence protocol in the Swift standard library, focusing on minElement() and maxElement() methods. Consider how to add protocol requirements for these methods to allow customization while maintaining backward compatibility. Look at existing swift evolution proposals for similar changes and check the swift dev mailing list for prior discussions.
[SR-888] Sequence.minElement() and maxElement() should be protocol requirements (customization points) · swiftlang/swift#43500 | Good First Issue