swiftlang/swift

[SR-888] Sequence.minElement() and maxElement() should be protocol requirements (customization points)

Open

#43,500 opened on Mar 6, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
affects ABIgood first issuestandard libraryswift evolution proposal needed

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-888
Radar rdar://problem/24999603
Original Reporter @gribozavr
Type Bug
Status In Progress
Resolution
Votes 0
Component/s Standard Library
Labels Bug, AffectsABI, StarterBug, StarterProposal, swift-evolution-proposal-needed
Assignee akhilmantha (JIRA)
Priority Medium

md5: 38f233c0b4c0d1508b74875d0c159d05

Issue Description:

Some collections naturally maintain sorted order and can implement `minElement()` and `maxElement()` in O(1). Thus, these algorithms should be protocol requirements to allow collection-specific customizations.

Note that `minElement()` and `maxElement()` that take predicates should continue to be pure extensions.

Contributor guide

Research direction
Analyze the Swift standard library to understand the existing Sequence protocol and implement minElement() and maxElement() as protocol requirements with default implementations for O(1) collections.
Tech stack
swift
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
SwiftProtocols
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75