swiftlang/swift

[SR-873] Python Benchmark Driver needs unit tests

Open

#43,485 opened on Mar 3, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
compilergood first issue

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-873
Radar None
Original Reporter @gottesmm
Type Task
Votes 0
Component/s Compiler
Labels Task, StarterBug
Assignee None
Priority Medium

md5: 9053a294b75b04073c72f457567c4ddd

Issue Description:

In https://bugs.swift.org/browse/SR-871, we discovered that the upper level python benchmark driver was using lexicographical comparison in order to calculate the minimum/max value/etc.

We should add some basic sanity checking here in terms of a nose test or something like that.

Contributor guide

Research direction
Identify the Python benchmark driver in the Swift repository, understand the current lexicographic comparison issue mentioned in SR 871, and write nose tests to verify correct min/max calculations.
Tech stack
python
Domain
testingtooling
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonbasic testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85