swiftlang/swift

[SR-540] eliminate the .cpp.gyb files from the source tree

Open

#43,157 opened on Jan 14, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcompilergood first issue

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-540
Radar None
Original Reporter @lattner
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ff02b1c09cc812ba86f097ddd5c3cf2d

Issue Description:

Gyb is a necessary artifact used in the standard library and test suite due to Swift not having a preprocessor. C++ on the other hand DOES have a preprocessor, so we should definitely not use gyb for .cpp files, we should use ".def" files consistently. Unfortunately we are using it in a couple of cases:

lib/Basic/UnicodeExtendedGraphemeClusters.cpp.gyb
stdlib/public/stubs/UnicodeExtendedGraphemeClusters.cpp.gyb
unittests/Basic/UnicodeGraphemeBreakTest.cpp.gyb

These should switch to using the C preprocessor.

Contributor guide

Research direction
Identify the .cpp.gyb files listed, understand how gyb generates C++ code, and replace the gyb templating with C preprocessor directives (#define, #if, etc.). Ensure the generated .cpp files remain identical.
Tech stack
swiftcpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftC++C preprocessor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80