swiftlang/swift

[SR-342] Convert or add *.sil version of all *.swift tests in test/SILOptimizer and test/IRGen

Open

#42,964 opened on Dec 22, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
bugcompilergood first issuenfc

Description
Previous ID SR-342
Radar None
Original Reporter @gottesmm
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: c67ceae294f0653e3d62193d939cc2e1

Issue Description:

Due to problems with the SILParser there are tests for the SILOptimizer and IRGen that were written as swift tests instead of *.sil tests.

Using *.swift tests allows for frontend changes to potentially cause a test to no longer test what it is supposed to test due to codegen changes.

This should expose additional bugs in the SILParser yielding further work.

Contributor guide

Tech stack
swift
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Knowledge of SILFamiliarity with Swift compiler test infrastructureAbility to write .sil tests
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Start by listing all .swift test files in test/SILOptimizer and test/IRGen directories. For each, check if a corresponding .sil version exists. If not, study the .swift test to understand the functionality being tested, then write a .sil test that reproduces the same behavior. Ensure the test compiles and runs correctly. Consult existing .sil tests in those directories for format and conventions. If any test is too complex or unclear, ask in the issue comments.
[SR-342] Convert or add *.sil version of all *.swift tests in test/SILOptimizer and test/IRGen · swiftlang/swift#42964 | Good First Issue