swiftlang/swift

[SR-341] Make test/SIL/Parser/witness_with_inherited_gp.sil not depend on stdlib and remove XFAIL

Open

#42,963 opened on Dec 22, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Swift (69,989 stars) (10,719 forks)batch import
bugcompilergood first issuenfc

Description
Previous ID SR-341
Radar None
Original Reporter @gottesmm
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: 8e2872d7bfc9887a64565cb007fd1902

Issue Description:

From Dmitri some months ago:

The test test/SIL/Parser/witness_with_inherited_gp.sil depends on the standard library implementation details (underscored protocols). It should define its own version of all protocols to ensure that it continues to test what was intended.

I'm making changes to these underscored protocols, the test broke, and I don't know how to update it properly.

I disabled the test.

Contributor guide

Tech stack
swift
Domain
testingbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SIL knowledgeSwift compiler build setupUnderstanding of XFAIL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requires modifying test/SIL/Parser/witness with inherited gp.sil to define its own version of the protocols it uses instead of relying on Swift standard library underscored protocols. Currently the test is XFAIL (expected failure) because changes to stdlib broke it. The fix involves replacing dependencies on stdlib protocols with locally defined protocols that replicate the necessary functionality. After implementing the changes, the XFAIL directive should be removed. The test should still verify the intended behavior related to witness tables with inherited generic parameters.