swiftlang/swift-package-manager

dynamically generate flag expectations in tests

Open

#5,474 opened on May 7, 2022

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)Swift (1,462 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (10,145 stars)
PR merge metrics
 (PR metrics pending)

Description

Many of the tests are currently statically generating the flags for expectations in BuildPlanTests.swift based upon #if os which changes behaviour based on the OS rather than the target. This can cause subtle bugs to arise. We should dynamically compute the arguments.

Contributor guide

Research direction
Review the current static flag generation in BuildPlanTests.swift and design a dynamic approach to compute the flags based on the target instead of the OS.
Tech stack
swift
Domain
build systemtesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75