swiftlang/swift-package-manager

dynamically generate flag expectations in tests

Open

#5474 opened on May 7, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Swift (10,145 stars) (1,462 forks)batch import
enhancementgood first issue

Description

Many of the tests are currently statically generating the flags for expectations in BuildPlanTests.swift based upon #if os which changes behaviour based on the OS rather than the target. This can cause subtle bugs to arise. We should dynamically compute the arguments.

Contributor guide

Tech stack
swift
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Swift knowledgeunderstanding of test infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue describes a need to replace static #if os flag expectations in BuildPlanTests.swift with dynamically computed arguments. Look at the test files in the SwiftPM repository, particularly around BuildPlanTests, and understand how flags are currently generated. The goal is to compute flags based on the target platform rather than the OS. No linked PRs or assignees; the discussion likely clarifies the approach. Investigate the existing test patterns and propose a method to dynamically generate the expected flags.