swagger-api/swagger-codegen

[Java] Getter/Setter naming convention not followed in generated models

Open

#8282 opened on Jun 5, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Language: javahelp wanted

Description

Description

When generating a client library (resttemplate), the getters/setters for a field xField are getXField and setXField. As per naming conventions, this is wrong: https://stackoverflow.com/questions/2948083/naming-convention-for-getters-setters-in-java

We found this issue when testing our API - the responses contained "xfield" and "xField" as jackson serializer did not match the field to the getter generated.

Swagger-codegen version

Using swagger codegen 2.3.1.

Swagger declaration file content or url
		  "xField" : {
			"type" : "string"
		  },
Command line used for generation

Using swagger-codegen-maven-plugin. Maven -> Generate sources

Steps to reproduce

Run generate-sources on a specification containing a field name in some object of form "xField" (a single lower case character followed by upper-case). Generated java model contains getXField() when it should be named getxField().

Suggest a fix/enhancement

Enhance whatever code creates getters and setters for fields in the specification.

Contributor guide

Tech stack
java
Domain
backendtoolingapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Java programmingswagger codegen codebaseOpenAPI/Swagger specs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is about incorrect getter/setter names for fields starting with a lowercase letter followed by uppercase (e.g., 'xField'). The fix involves locating the code in swagger codegen that generates getter/setter method names, likely in DefaultCodegen or related template files. The current logic produces 'getXField' for 'xField', but should produce 'getxField' (lowercase second character) to follow Java bean naming conventions. Check the method that constructs property names, and ensure it handles such cases correctly. There is no linked PR or recent activity, so the issue is still open for contribution.