swagger-api/swagger-codegen

deferred.fulfill for a Promise<Void> has issue with latest PMK, Swift4 & Xcode 9

Open

#7005 opened on Nov 20, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: SwiftIssue: Bughelp wanted

Description

Problem with your promises implementation....for the latest PromiseKit for a Promise{Void}, you are generating: deferred.fulfill( ) when you should generate deferred.fulfill( () ) Note the extra parens as the void arg

Contributor guide

Tech stack
swift
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift basicsPromiseKit familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the template file responsible for generating PromiseKit Swift code, likely a Mustache template. Search for 'deferred.fulfill' and modify the argument for Void promises to use '()' instead of empty parentheses.