swagger-api/swagger-codegen

nodejs-server not respecting javascript reserved words.

Open

#6372 opened on Aug 24, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Issue: BugServer: Nodejshelp wanted

Description

One of the generated controller functions has the javascript reserved name "delete", which makes npm start fail.

module.exports.delete = function delete (req, res, next) { ManageNetworks.delete(req.swagger.params, res, next); };

Contributor guide

Tech stack
javascriptnodejsexpress
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsswagger codegen template structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The issue is that the generated Node.js server controller uses the JavaScript reserved word 'delete' as a function name, causing a runtime error. The fix involves locating the template file responsible for generating controller functions (likely in modules/swagger codegen/src/main/resources/nodejs server/). In that template, ensure that generated function names are escaped or prefixed to avoid reserved words. Check the mustache template files for the pattern that outputs function names and modify it to handle reserved words appropriately. The existing comments or linked PRs may provide additional context.