swagger-api/swagger-codegen

nodejs-server not respecting javascript reserved words.

Open

#6,372 opened on Aug 24, 2017

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)HTML (5,474 forks)batch import
Issue: BugServer: Nodejshelp wanted

Repository metrics

Stars
 (12,701 stars)
PR merge metrics
 (PR metrics pending)

Description

One of the generated controller functions has the javascript reserved name "delete", which makes npm start fail.

module.exports.delete = function delete (req, res, next) { ManageNetworks.delete(req.swagger.params, res, next); };

Contributor guide

Research direction
Investigate the template file that generates controller functions for nodejs server and add a check to escape JavaScript reserved words like 'delete'.
Tech stack
javascriptnodejs
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70