swagger-api/swagger-codegen

Apex Petstore sample client errors

Open

#6146 opened on Jul 22, 2017

View on GitHub
 (7 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: ApexIssue: Bughelp wanted

Description

Description

2 generated client classes (SwagPetApiTest, SwagStoreApiTest) are not compilable due to syntax errors.

Swagger-codegen version

2.2.3

Swagger declaration file content or url

http://petstore.swagger.io/v2/swagger.json

Command line used for generation

java -jar swagger-codegen-cli.jar generate -i http://petstore.swagger.io/v2/swagger.json -l apex

Steps to reproduce

Attempt to deploy SwagPetApiTest, SwagStoreApiTest to a Salesforce org. Deployment errors as follows (Eclipse Force.com IDE):

Description Resource Path Location Type Save error: Expression cannot be a statement. SwagPetApiTest.cls src/classes line 139 Force.com save problem Save error: Expression cannot be a statement. SwagStoreApiTest.cls src/classes line 46 Force.com save problem Save error: unexpected syntax: 'missing RPAREN at ';'' SwagPetApiTest.cls src/classes line 139 Force.com save problem Save error: unexpected syntax: 'missing RPAREN at ';'' SwagStoreApiTest.cls src/classes line 46 Force.com save problem

Related issues/PRs

None identified

Suggest a fix/enhancement

Erroring lines in the two classes are the same: ((Swagger.ApiKeyAuth) client.getAuthentication('api_key');

Fixed the client manually by changing the lines to: client.getAuthentication('api_key');

Contributor guide

Tech stack
java
Domain
apitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Apex language basicsSwagger codegen template structureJava mustache templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The error is in two generated Apex test classes (SwagPetApiTest, SwagStoreApiTest) where the line `((Swagger.ApiKeyAuth) client.getAuthentication('api key');` has a syntax error. The fix is to remove the cast, resulting in `client.getAuthentication('api key');`. To implement the fix, locate the mustache template that generates this line, likely in the Apex codegen module, and correct the expression. Check if there are any open pull requests or comments that already address this issue. The relevant files are likely in modules/swagger codegen/src/main/resources/apex/ or similar.