swagger-api/swagger-codegen

[Spring] The java8 parameter is ignored, always behaves as true

Open

#5614 opened on May 11, 2017

View on GitHub
 (11 comments) (2 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Issue: BugServer: Springhelp wanted

Description

Description

The java8 parameter in the spring generator is ignored, always behaves as true. It doesn't matter that it's specified explicitly or not. The generated code always contains Java 8 default interfaces.

Swagger-codegen version

Latest from master.

Command line used for generation

java -jar swagger-codegen-cli.jar generate -i swagger.json -l spring -o build -D hideGenerationTimestamp=true --invoker-package custom.package --model-package custom.package.model --api-package custom.package.api --additional-properties dateLibrary=java8-localdatetime,basePackage=custom,configPackage=custom.swagger,useBeanValidation=true,java8=false

Steps to reproduce

Execute the given command with any valid JSON file.

Suggest a Fix

I guess the issue is in the SpringCodegen.java, but haven't checked thoroughly.

Contributor guide

Tech stack
javaspring
Domain
backendapitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaSpringSwagger Codegen
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the SpringCodegen.java file in the swagger codegen repository to understand how the java8 parameter is processed. Review the comments on the issue for any additional context or attempts. Check if the parameter is correctly passed to the template engine and ensure that when set to false, it does not generate Java 8 default interfaces. The issue suggests that the parameter is always treated as true, so look for inconsistent handling or default values in the code.