swagger-api/swagger-codegen

[Swift3] Boolean are converted to Strings in Json

Open

#5,543 opened on May 3, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: SwiftIssue: Bughelp wanted

Description

I'm not sure which commit changed this, but the newest client pickles booleans like this:

"boolprop": "false"

and it should be like this:

"boolprop": false

Contributor guide

Tech stack
swift
Domain
apibackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Swift basicsJSON specificationSwagger code generation templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about Swift3 code generation in swagger codegen. The boolean values in JSON are incorrectly serialized as strings. To fix, locate the Swift template files (likely in modules/swagger codegen/src/main/resources/swift/ or similar) and ensure that boolean properties are output without quotes. Check the mustache templates for the JSON serialization logic. A fix might involve changing the template to output `{{value}}` instead of `"{{value}}"` for booleans. Look for existing PRs or comments for hints.