swagger-api/swagger-codegen

Update test cases for JSON MIME type detection

Open

#5,261 opened on Mar 30, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Enhancement: CI/Testhelp wanted

Description

Description

We'll leverage the additional tests cases added via for other langauges (PHP, Ruby, etc) so as to ensure other API clients can also handle these edge cases.

Swagger-codegen version

Latest master

Related issues

https://github.com/swagger-api/swagger-codegen/pull/5189

Suggest a Fix

Test cases: https://github.com/davidharrigan/swagger-codegen/blob/c31d597747b99c08774105d5eab0ca9eacc0c593/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/ApiClientTest.java#L80-L102

If anyone wants to work on this, please reply to let us know.

Contributor guide

Tech stack
javaphprubyrest api
Domain
testingapi
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic Java knowledgeSwagger codegen familiarityJSON MIME type understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the linked PR #5189 for context on additional test cases added for other languages. Examine the test file at samples/client/petstore/java/okhttp gson/src/test/java/io/swagger/client/ApiClientTest.java lines 80-102 for existing Java JSON MIME type detection tests. Then add similar tests for PHP and Ruby client code, covering edge cases like charset handling and vendor specific MIME types.