swagger-api/swagger-codegen

Empty response body handling in typescript-angular2

Open

#4,962 opened on Mar 7, 2017

View on GitHub
 (24 comments) (4 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: TypeScriptIssue: Bughelp wanted

Description

Description

Empty response 200 OK codes are not handled by auto generated api code.

Swagger-codegen version

2.2.2

Swagger declaration file content or url
Command line used for generation

language: typescript-angular2

Steps to reproduce

Build an api response just give 200 as http code but no response body

Suggest a Fix

Here's the current api.mustache at line 45;

return response.json()

It should be;

return response.json() || {};

Contributor guide

Tech stack
typescripthtml
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic TypeScript knowledgeunderstanding of mustache templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The fix is in the api.mustache template file for typescript angular2, specifically line 45 where `return response.json()` is called. Change it to `return response.json() || {};` to handle empty 200 response bodies. Ensure the change is tested and doesn't break other scenarios. See the template at https://github.com/swagger api/swagger codegen/blob/master/modules/swagger codegen/src/main/resources/typescript angular2/api.mustache (or similar path).