swagger-api/swagger-codegen

[Python] No way to handle exceptions in asyncronous code (with callback)

Open

#4,235 opened on Nov 22, 2016

View on GitHub
 (11 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: PythonIssue: Bughelp wanted

Description

Description

Produced by codegen Python code does not support handling of exceptions in anync mode (with callback). If swagger client code raises exeption, callback will never be called.

Swagger-codegen version

5

Command line used for generation

-l python

Suggest a Fix

Catch all exceptions in generated swagger client and return special type of result in case of exceptions.

Contributor guide

Tech stack
python
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python async/awaitswagger codegen templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the Python asynchronous client templates in the swagger codegen repository (likely under modules/swagger codegen/src/main/resources/python/). Look for how callbacks are currently implemented and identify where exceptions are not caught. Propose wrapping the callback call in a try except block and returning a custom error result object. Check the issue comments for any prior discussion or proposed approaches.
[Python] No way to handle exceptions in asyncronous code (with callback) · swagger-api/swagger-codegen#4235 | Good First Issue