swagger-api/swagger-codegen

Android Codegenerator generates import statement for APIs without models

Open

#3,956 opened on Oct 9, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: AndroidIssue: Bughelp wanted

Description

Description

Android Codegenerator generates import statement for APIs without models. This results in the compiler not to be able to resolve the term "Model" in import io.swagger.client.model.*;

Swagger-codegen version

Swagger version: 2.2.1, tagged zip downloaded and installed by maven on windows

Swagger declaration file content or url

Any file that doesnt produce any models

Command line used for generation

java -jar ../swagger-codegen-2.2.1/modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate -i >URL to declaration file< -l android

Steps to reproduce

Generate the code - done

Related issues

nothing found. sorry

Suggest a Fix

the import statement should be omittet if there are no models

Contributor guide

Tech stack
javaandroid
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Android code generationFamiliarity with swagger codegen templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is that the Android code generator unconditionally adds the import statement 'import io.swagger.client.model.*' even when there are no models. The fix should modify the Android template (likely located in modules/swagger codegen/src/main/resources/.../android/...) to conditionally include this import only if models are present. Check the Mustache template variables for model count. Similar fixes in other languages may provide guidance. No linked PRs or maintainer comments found; the issue is self contained.