swagger-api/swagger-codegen

[Android] Client doesn't call setDateFormat() on GsonBuilder object correctly

Open

#3,590 opened on Aug 15, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: AndroidIssue: Bughelp wanted

Description

Description

I get ApiException when Swagger tries to retrieve the following JSON: {"apiVersion":1,"providerID":9999999999,"timeStamp":"2016-08-15T14:38:36.172Z"}

The root cause is that JsonUtil.java calls

gsonBuilder.setDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ");

instead of calling it with single quotes around the "Z"

gsonBuilder.setDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");

2.0
Swagger declaration file content or url
Command line used for generation
Steps to reproduce

Specify the format of a yaml field to "date-time"

Related issues
Suggest a Fix

Add single quotes around the "Z" character in the String argument to gsonBuilder.setDateFormat()

Contributor guide

Tech stack
javaandroid
Domain
apimobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaGsonDate formatting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look at the file `modules/swagger codegen/src/main/java/io/swagger/codegen/languages/AndroidClientCodegen.java` or the generated `JsonUtil.java`. The issue is that `setDateFormat` is called without single quotes around the 'Z'. The fix is to add single quotes as shown in the issue description. Check the code generation template for date formatting to ensure the correct pattern is used.