swagger-api/swagger-codegen

[Javascript] Problems on deserialize text type and on file response

Open

#3,297 opened on Jul 5, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)HTML (5,474 forks)batch import
Client: JavaScript/Node.jsIssue: Bughelp wanted

Repository metrics

Stars
 (12,701 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, I'm testing my api on the generated nodejs(javascript) client. I've found two problems, that break the client when called. First: when I've a call that return text/plain, SuperAgent initialize the body to {}, so data it's never null and doesn't verify the if condition, and in the end it gives an error. deserialize I've done a fix for my case, just adding this line in the if clauses "if (data == null || (returnType==='String' && Object.keys(data).length === 0 && data.constructor === Object))" but I think this is a bug and has to be correct

Second: I've a call where the response is a file file And this is fine on other language like java or ruby, but not on javascript. It gives this error: file2

Thanks in advance for support

I'm using Swagger-codegen version 2.2.0

Contributor guide

Research direction
Inspect the deserialization logic in the JavaScript client template (default.js) and the file response handling to fix text/plain response decoding and file response errors.
Tech stack
javascript
Domain
apitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptSuperAgent
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65