swagger-api/swagger-codegen

[Swift] Getting 'CANCELLED' for incorrect credentials instead of 401

Open

#3,097 opened on Jun 9, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: SwiftIssue: Bughelp wanted

Description

Description

I am building an app that has a sign in using http basic authentication. If the credentials are correct, it works fine. However for invalid credentials, I cannot access the status code (to test for 401) and the errors localizedDescription shows: cancelled

Swagger-codegen version

generated online

Swagger declaration file content or url
Command line used for generation
Steps to reproduce

Log in using HTTP Basic auth with incorrect credentials

Related issues
Suggest a Fix

pass the status code even if there is a failure.

Contributor guide

Tech stack
swiftrest api
Domain
apiauthentication
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic Swift networking knowledgeHTTP status codesFamiliarity with swagger codegen templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue involves the generated Swift client not passing HTTP status codes on failure. First, examine the Swift template files (likely under modules/swagger codegen/src/main/resources/swift/) for how HTTP responses are handled. Look for code that cancels the request on non 2xx statuses instead of returning the error with the status code. The fix should modify the template to include the HTTP status code in the error object or callback. Check if the issue has been discussed in related PRs or comments. Reproduce with a simple API definition containing HTTP Basic auth and incorrect credentials to confirm the behavior.
[Swift] Getting 'CANCELLED' for incorrect credentials instead of 401 · swagger-api/swagger-codegen#3097 | Good First Issue