swagger-api/swagger-codegen

Swift GET parameters are not URL encoded

Open

#3,037 opened on Jun 3, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (5,474 forks)batch import
Client: SwiftIssue: Bughelp wanted

Repository metrics

Stars
 (12,701 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

Generated Swift clients do not URL-encode GET parameters. This must be done if a GET parameter contains characters like slash ('/') or pipe ('|')

Swagger-codegen version

Swagger 2.2.0

Suggest a Fix

URL-encode all parameters by calling object.stringByAddingPercentEncodingWithAllowedCharacters(.URLHostAllowedCharacterSet())

Contributor guide

Research direction
Inspect the Swift template files in the swagger codegen repository and add URL encoding for GET parameters using stringByAddingPercentEncodingWithAllowedCharacters.
Tech stack
swift
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70