swagger-api/swagger-codegen

[swift] query params on put get ignored if URL is a type

Open

#2,978 opened on May 26, 2016

View on GitHub
 (10 comments) (0 reactions) (0 assignees)HTML (5,474 forks)batch import
Client: SwiftIssue: Bughelp wanted

Repository metrics

Stars
 (12,701 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

If the endpoint takes a query param in PUT request the alamofire ignores the parameters

Swagger-codegen version

2.1.6

Swagger declaration file content or url

https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/swift/default/PetstoreClient/Classes/Swaggers/AlamofireImplementations.swift#L31

Command line used for generation
Steps to reproduce
Related issues

I reported a bug in Alamofire as well https://github.com/Alamofire/Alamofire/issues/1275

Suggest a Fix

use Alamofire.ParameterEncoding.URLEncodedInURL ?

Contributor guide

Research direction
Investigate the Alamofire PUT request encoding in the generated Swift code; consider using Alamofire.ParameterEncoding.URLEncodedInURL for query parameters.
Tech stack
swift
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftAlamofire
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60