swagger-api/swagger-codegen

Angular 1 gen - Add basePath to inject and allow empty basepath

Open

#2,788 opened on May 6, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (5,474 forks)batch import
Client: TypeScriptEnhancement: Generalhelp wanted

Repository metrics

Stars
 (12,701 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Add basePath to the inject array. In order to be able to use angular DI with a different basepath.

If base path is not present in inject array angular DI cannot resolve basePath when uglified.

Check for if(basePath !== undefined) instead of if(basepath) to allow an empty basePath

An empty basepath is handy when the API resides on the same host as the application

static $inject: string[] = ['$http', '$httpParamSerializer','basePath'];

constructor(protected $http: ng.IHttpService, protected $httpParamSerializer?: (d: any) => any, basePath?: string) { if (basePath !== undefined) { this.basePath = basePath; } }

Contributor guide

Research direction
Locate the Angular 1 template for the API service in swagger codegen. Add basePath to the $inject array and change the constructor condition from if(basePath) to if(basePath !== undefined) to allow empty basePath.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptAngular dependency injection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80