swagger-api/swagger-codegen

Underscore prefix dropped from property names in generated Node Typescript classes

Open

#2,766 opened on May 3, 2016

View on GitHub
 (7 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: TypeScriptIssue: Bughelp wanted

Description

From @saikatguha on April 29, 2016 22:9

"Foo": {
  "type": "object",
  "properties": {
    "_links": { "$ref": "#/definitions/Bar" }
  }
}

becomes

class Foo {
  "links": Bar;
}

Copied from original issue: swagger-api/swagger-editor#905

Contributor guide

Tech stack
typescript
Domain
apitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScriptSwagger/OpenAPI specificationTemplate engine (Mustache)
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the TypeScript code generation templates in the swagger codegen repository, specifically the Mustache template for property names. Look for where the underscore prefix is stripped, possibly in the 'property' template or the language specific type mapping. Check the issue comments for any proposed fixes or discussions. Determine if the issue is still reproducible with the latest version of swagger codegen.
Underscore prefix dropped from property names in generated Node Typescript classes · swagger-api/swagger-codegen#2766 | Good First Issue