swagger-api/swagger-codegen

[Go] Generated client code doesn't return specified error objects for non-2xx response codes

Open

#2,296 opened on Mar 2, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: GoEnhancement: Generalhelp wanted

Description

Currently the generated code (DefaultApi) does return an error code if a non-2xx HTTP condition occurs (ie an error), but it ignores what the swagger says it should produce. E.g. if the swagger states that a 404 returns a petNotFoundError object, currently the Go code generator ignores this fact.

Contributor guide

Tech stack
gorest api
Domain
apibackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingSwagger/OpenAPI specCode generation templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue states that generated Go client code ignores specified error objects for non 2xx responses. Investigate the Go code generation templates in the modules/swagger codegen/src/main/resources/go/ directory. Look for how error handling is currently implemented in generated DefaultApi and how it could be modified to return the proper error objects as per the Swagger spec. The issue has not seen recent activity, so maintainer clarification may be needed on the exact expected behavior.