swagger-api/swagger-codegen

node.js generator can create invalid package.json files

Open

#2,088 opened on Feb 9, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (5,474 forks)batch import
Enhancement: GeneralServer: Nodejshelp wanted

Repository metrics

Stars
 (12,701 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

We need to properly escape the name, and version as well.

For instance:

name: "it's bad",
version: "1"

Will give an error on the name and the version as well.

Reported by @kesh92

Contributor guide

Research direction
Find the template file for package.json in the node.js generator and apply proper escaping to the name and version fields to handle special characters like apostrophes.
Tech stack
None
Domain
backendapitooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80