sveltejs/kit

Add typescript eslint rules

Closed

#3,457 opened on Jan 20, 2022

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,719 forks)batch import
help wantedtypes / typescript

Repository metrics

Stars
 (17,446 stars)
PR merge metrics
 (Avg merge 17d 22h) (184 merged PRs in 30d)

Description

Describe the problem

The lack of eslint rules for the declaration files allow the type declarations to be inconsistent, specifically preferring interfaces over types or vice-versa and using the method notation (name(): ReturnType) over the function field notation (name: () => ReturnType).

Describe the proposed solution

Installing the typescript eslint packages to enforce style rules.

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.