supasate/connected-react-router

Browser history stack is modified when time travelling

Open

#36 opened on Feb 19, 2017

View on GitHub
 (0 comments) (3 reactions) (0 assignees)JavaScript (4,741 stars) (606 forks)batch import
bughelp wanted

Description

Currently, when we do time travelling, the ConnectedRouter tries to change the URL bar to match the router state in the redux store (which is changed by Redux DevTools) by using history.push (see here).

This method seems to work fine, however, internally, the real browser history stack is modified (new history is pushed on top of the stack). It would be better if we can change the URL by just moving the pointer in the history stack to match time travelling.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactReduxbrowser history API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the ConnectedRouter.js file, specifically the code at line 40 where history.push is called during time travel. Consider replacing history.push with history.replace or manipulating the history stack index directly to avoid adding new entries. Review the react router documentation on history objects for alternatives.