stylus/stylus

Normalizer fails when selector.val is undefined

Open

#2,327 opened on Sep 15, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,173 forks)batch import
good first issuet: Enhancement

Repository metrics

Stars
 (11,125 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Line 247: normalizer.js

   // normalize interpolated selectors with comma
  group.nodes.forEach(function(selector, i){
    if (!~selector.val.indexOf(',')) return;
    if (~selector.val.indexOf('\\,')) {
      selector.val = selector.val.replace(/\\,/g, ',');
      return;
    }

Contributor guide

Research direction
Identify where selector.val can be undefined and add a guard check before calling indexOf.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70