stride3d/stride

[Animation] Messy curve/animation/evaluator API

Open

#449 opened on May 18, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (6,001 stars) (886 forks)batch import
area-Graphicsenhancementgood first issue

Description

Release Type: Github

Version: Latest

Platform(s): Any

Describe the bug The animation/curve API as it is is not very maintainable and quite restrictive, there's no reason now that generics supports unmanaged and interface type constraints to have two implementation of a class differing in only the generic type they chose, ex : AnimationCurveEvaluatorOptimizedVector3Group / AnimationCurveEvaluatorOptimizedVector4Group. We can replace 2/3 of the files within /Animations by implementing and adding an IInterpolation interface on our math types and including it as a constraint on our generics requiring that kind of features.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# genericsinterface constraintsStride animation systemgame engine math types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the existing animation curve evaluator classes in the Animations directory (e.g., AnimationCurveEvaluatorOptimizedVector3Group.cs, AnimationCurveEvaluatorOptimizedVector4Group.cs) to identify all duplicated implementations. Propose a generic interface IInterpolation<T> for math types (Vector3, Vector4, etc.) and refactor the evaluators to use a single generic class with the IInterpolation constraint. Ensure the solution compiles and passes existing tests.
[Animation] Messy curve/animation/evaluator API · stride3d/stride#449 | Good First Issue