stride3d/stride

[Launcher] Check for disabledPackageSources (in NuGet.config)

Open

#287 opened on Dec 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (6,001 stars) (886 forks)batch import
area-Launcherenhancementgood first issue

Description

Release Type: Official Release

Version: Xenko Launcher 3.0.1

Platform(s): Windows

Describe the bug Because Xenko Launcher doesn't check for disablePackageSources in NuGet.conf, if the xenko nuget packages are disabled, the xenko launcher will think it's offline and won't be able to connect to the internet to download the xenko builds from the internet

To Reproduce Steps to reproduce the behavior:

  1. open NuGet.config in %APPDATA%\NuGet\NuGet.config
  2. add these lines in configuration
<disabledPackageSources>
    <add key="Xenko" value="true" />
    <add key="Xenko Dev" value="true" />
  </disabledPackageSources>
  1. The Xenko launcher cannot connect and download xenko builds

Expected behavior The launcher should check if the xenko package are disabled and automatically enable them, or ask the user the authorization to enable them

Screenshots unknown

Contributor guide

Tech stack
csharp
Domain
desktoptooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#NuGet configuration
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how the Xenko launcher currently reads NuGet.config to determine if it's offline. In particular, check if the launcher has any existing code to parse disabledPackageSources. Look for references to 'NuGet' in the launcher source code, likely in the Launcher project. The fix should either automatically enable the disabled Xenko packages or prompt the user, as described in the expected behavior. Consider using NuGet's configuration API to read and modify disabledPackageSources.
[Launcher] Check for disabledPackageSources (in NuGet.config) · stride3d/stride#287 | Good First Issue