stretchr/testify

assert: NotNil accepts non-nillable types and doesn't fail

Open

#570 opened on Mar 7, 2018

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Go (1,704 forks)batch import
help wanted

Repository metrics

Stars
 (25,958 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/stretchr/testify/blob/b89eecf5ca5db6d3ba60b237ffe3df7bafb7662f/assert/assertions.go#L390-L410

isNil will always return false, so NotNil will always return true for int, string, struct, etc.

I would expect it to error with "invalid type".

Contributor guide

Research direction
Examine the 'isNil' function in assert/assertions.go and modify 'NotNil' to reject non nillable types.
Tech stack
go
Domain
testing qa
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gotestify
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70