stretchr/testify

assert: NotNil accepts non-nillable types and doesn't fail

Open

#570 opened on Mar 7, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (25,958 stars) (1,704 forks)batch import
help wanted

Description

https://github.com/stretchr/testify/blob/b89eecf5ca5db6d3ba60b237ffe3df7bafb7662f/assert/assertions.go#L390-L410

isNil will always return false, so NotNil will always return true for int, string, struct, etc.

I would expect it to error with "invalid type".

Contributor guide

Tech stack
go
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go nil basicstestify assert package
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the NotNil function in assert/assertions.go (lines 390-410). Understand how isNil works and why it always returns false for non nillable types. Then modify NotNil to first check if the type is nillable using reflect and return an error message 'invalid type' if not. See related discussions in comments.