stretchr/testify

Equal diff prints uints in hex format

Open

#400 opened on Feb 14, 2017

View on GitHub
 (5 comments) (13 reactions) (0 assignees)Go (25,958 stars) (1,704 forks)batch import
assert.EqualValuesenhancementenhancement: output formathelp wantedpkg-assertrevisit

Description

Equal and EqualValues print uints in hex format when showing diff. It would be much more useful to see 1701, instead of 0x6a5.

Error Trace:    equality_test:34
        Error:          Not equal:
                        expected: float64(1700)
                        received: uint(0x6a5)
        Messages:       Expecting prices to be equal

Contributor guide

Tech stack
go
Domain
testingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go basicsfamiliarity with testify
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the code in testify that prints the diff. Likely in a file like 'equality.go' or similar. Look for the format string that uses '%x' for uints and change it to '%d'. Check if any existing tests need to be updated. Also consider if the same change applies to other numeric types.