stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 opened on Nov 5, 2015

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (25,958 stars) (1,704 forks)batch import
enhancementhelp wanted

Description

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

Contributor guide

Tech stack
go
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Research the existing implementations of Equal and EqualValues in the testify codebase. Check for any existing tests that fail when types differ. Review the 10 comments for additional context and any consensus on direction. Consider backward compatibility and whether a new function might be safer.