stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 opened on Nov 5, 2015

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (1,704 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (25,958 stars)
PR merge metrics
 (Avg merge 6d 15h) (2 merged PRs in 30d)

Description

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

Contributor guide

Research direction
Investigate Go type coercion rules and identify cases where asserting equality with `Equal` would incorrectly pass for different types that are assignable via `EqualValues`.
Tech stack
go
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60