stretchr/testify

proposal: analogue of `InDeltaMapValues` with different deltas

Open

#1,496 opened on Oct 29, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (25,958 stars) (1,704 forks)batch import
help wanted

Description

Hi!

Looks like InDeltaMapValues doesn't make sense if I need different deltas for different keys.

Thanks.

Contributor guide

Tech stack
go
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingtestify package familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue requests a new function similar to InDeltaMapValues but allowing different delta values per key. Start by examining the current implementation of InDeltaMapValues in assert/assertions.go. Review the 3 comments on the issue for any design considerations. Propose a new function signature, e.g., InDeltaMapValuesWithDeltas(expected, actual map[string]float64, deltas map[string]float64). Ensure the implementation follows testify's existing patterns for reporting failures.