streetwriters/notesnook

Moving editor tools around doesn't update indentation

Open

#4350 opened on Feb 25, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (5,325 stars) (285 forks)batch import
Platform: WebStatus: InvestigatingUnit: UI/UXgood first issue

Description

Really minor thing, doesn't break or cause a problem, just a UI glitch...

When moving an editor toolbar item out of a subgroup in to its parent, the indentation is still the same as if it were in the subgroup. (e.g. move code < > item out of subgroup 2 in to the main toolbar) It doesn't affect anything, and is fine when going out and back in to settings.

Device information: App version: 2.6.15-aa730b5-desktop OS: OS X 10.15.7 Browser: Electron 25.9.8 Pro: true

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with editor toolbar UI components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug occurs when moving a toolbar item from a subgroup to the parent toolbar; the indentation does not update. Investigate the editor toolbar rendering logic, likely in the `editor` package or component. Check how indentation is calculated and whether it is re evaluated on item move. Look for any logic that sets indentation based on subgroup membership and ensure it triggers a re render or update when the parent changes. No existing PRs or comments provide further clues.