streetwriters/notesnook

Unable to select text from start or end of in line code

Open

#2,792 opened on Jun 22, 2023

View on GitHub
 (9 comments) (0 reactions) (1 assignee)JavaScript (5,325 stars) (285 forks)batch import
Platform: DesktopPlatform: WebStatus: ConfirmedType: Buggood first issueplane

Description

What happened?

Trying to select from either end of a line consisting only of inline code will fail. No selection will occur and cursor will simply reposition.

Steps to reproduce the problem

  • Write any inline code such that it becomes the end of the line or it is at the start of the line.
    • Eg: 
      Start ssh-agent in fish shell:
`eval (ssh-agent -c)`
  • Trying to select from either end of the inline code will fail

Version

v2.5.3

Platform/OS

Windows, Linux

Relevant log output

No response

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript basicsDOM selection API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the text selection behavior in the Notesnook editor when inline code is at line boundaries. Examine the editor component's selection handling code (likely in the editor's Slate or custom implementation) to understand why selection fails from the start or end of inline code. Use browser devtools to trace selection events and review the issue comments for any clues. Check for existing tests related to inline code selection to replicate the bug.