Confusing subscriptions expire docs

Open
#707 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
cli, documentation

Research direction

Start with the pulsarctl subscriptions expire help text and the documentation covering its -t and -a flags. Clarify that -t expires one matching message unless -a is supplied, while -a expires all messages, then verify the wording matches the command behavior.

Written by the indexing model from the issue text.

Description

Hello, first of all I really like and enjoy using this tool 🙂

Some time ago I was trying to expire a couple of messaged from pulsar using pulsarctl subscriptions expire. I checked the docs:

ExpireMessages flags:
  -t, --expire-time int   Expire messages older than time in seconds
  -a, --all               Expire all messages

So I executed pulsarctl subscriptions expire -t 5 ... and expected that all messages older than 5 second will be expired, but after some poking around I realised that only one was.

I think that this is a little bit misleading - I though that -t will expire ALL messages older than int but it turned out that if -a is not specified it expire only a single message - my thinking was -a expired ALL messaged no matter what time they were published.

Do you think it would be worth reflecting that behaviour more clearly in the docs?

Dominant language
Go
Stars
169
Forks
68
Avg merge
5m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from streamnative/pulsarctl

All issues in streamnative/pulsarctl

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.