streamich/react-use

`createGlobalState` should use `useIsomorphicLayoutEffect`

Open

#956 opened on Feb 7, 2020

View on GitHub
 (2 comments) (3 reactions) (0 assignees)TypeScript (3,273 forks)batch import
bugenhancementgood first issuehelp wanted

Repository metrics

Stars
 (43,979 stars)
PR merge metrics
 (Avg merge 1743d 9h) (1 merged PR in 30d)

Description

currently the hook generated by the createGlobalState call will warn server side, due to the useLayoutEffect call.

Contributor guide

Research direction
Replace the useLayoutEffect call with useIsomorphicLayoutEffect from react use or a custom implementation to avoid SSR warnings.
Tech stack
javascripttypescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90