streamich/react-use

`createGlobalState` should use `useIsomorphicLayoutEffect`

Open

#956 opened on Feb 7, 2020

View on GitHub
 (1 comment) (3 reactions) (0 assignees)TypeScript (43,979 stars) (3,273 forks)batch import
bugenhancementgood first issuehelp wanted

Description

currently the hook generated by the createGlobalState call will warn server side, due to the useLayoutEffect call.

Contributor guide

Tech stack
reacttypescript
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic React hooks knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the createGlobalState function in the source code (likely in src/ or hooks/). Replace the useLayoutEffect call with useIsomorphicLayoutEffect, which can be imported from 'react use' or from 'react' depending on the library's setup. Ensure the import is added if not present. The fix is straightforward and should resolve the SSR warning.