streamich/react-use

useLockBodyScroll doesn't restore scroll position

Open

#840 opened on Dec 16, 2019

View on GitHub
 (7 comments) (0 reactions) (1 assignee)TypeScript (3,273 forks)batch import
bughelp wanted

Repository metrics

Stars
 (43,979 stars)
PR merge metrics
 (Avg merge 1743d 9h) (1 merged PR in 30d)

Description

What is the current behavior?

When useLockBodyScroll is passed a value of false, it does re-enable scrolling, however any previous scroll position is not restored.

What is the expected behavior?

The previous scroll position should be restored to the scrolled element.

A little about versions:

  • OS:
  • Browser (vendor and version):
  • React: 16.11.0
  • react-use: 13.10.1

Contributor guide

Research direction
Investigate the implementation of useLockBodyScroll to see how scroll position is saved and restored. Check if window.pageYOffset or element.scrollTop is stored and correctly applied when unlocking.
Tech stack
reacttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactDOM manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65